On Wednesday 11 June 2003 05:55, Jim Muchow wrote: > I subscribed to the yaffs mailing list but there doesn't > seem to be any traffic or an archives. If you would prefer > that I ask this question in another venue, please tell > me. The yaffs list isn't very bust right now and often gets blocked by some mail problem. It is the right place to submit questions, but feel free to send to me directly too. > > In yaffs_IsBlockBad() a test is made for the number of bits > in each byte. The original test for 0xFF is #if'd out. > > The test for failure is less than 7. Shouldn't this be 8? > Or less than or equal? What am I missing? The bad block marker should be either 0 (bad) or 0xFF (good). Counting the bits allows us to cover for single bit errors. ie. I reckon it is OK to accept a block with 7 bits set. Note that this bad block detection strategy will not work with all devices. -- CHarles --------------------------------------------------------------------------------------- This mailing list is hosted by Toby Churchill open software (www.toby-churchill.org). If mailing list membership is no longer wanted you can remove yourself from the list by sending an email to yaffs-request@toby-churchill.org with the text "unsubscribe" (without the quotes) as the subject.