I've just checked in a huge patch making yaffs2 follow the Linux kernel code style (as defined by checkpatch.pl). Sorry about the mess this will make of any existing patches you are working with, and general pain, but the last time we tidied things up was August 2005, and this is a necessary prerequisite to getting yaffs into mainline. We've tried hard not to change anything other than style, and the new code is working fine here with 2.9.29-rc7, but do tell us if you find problems. There is a tag 'pre-checkpatch-20090306' for the codebase as of last night which includes all the recent 2.6.29 fixes. If that works for you and current HEAD doesn't then it's probably my/Noodles fault. Wookey -- Principal hats: iEndian - Balloonboard - Toby Churchill - Emdebian http://wookware.org/