On Tuesday 15 December 2009 06:34:43 Chris David wrote:
> Hi Charles,
>
> I just wanted to state for the record that I am happy with the
> behavior of yaffs_guts.c revision 1.98 in terms of fixing the symlink
> delete issue.
>
> I was able to replicate the issue by simply creating a symbolic link,
> then deleting it, then immediately pulling the power.  I did 4 runs
> like this, and the fs became unmountable somewhere between 237 and 405
> attempts.  For the record, this was on a '12:30pm PST on Nov 6, 2007'
> snapshot.  Then, I rebuilt with a '1:30pm PST on Dec 7, 2009'
> snapshot, and it did 5,755 attempts with no problems.
>
> And also, the new code was able to mount a filesystem generated by the
> previous code, that the previous code could not mount.
>
> Thanks for your efforts in fixing this.

Thanks for those significant test efforts.

I was able to reproduce the invalid dereference by running the code in a test 
harness with valgrind. Problem went away with the fix.

-- CHarles