Hey gang,

Whoops missed one more compile error.  Revised Thomas patch is included.

Changed:

+			retval = mtd->read_ecc(mtd,addr,dev->nBytesPerChunk,
dummy,data,tmpSpare,yaffs_oobinfo);

To:
+			retval =
mtd->read_ecc(mtd,addr,dev->nBytesPerChunk,&dummy,data,tmpSpare,&yaffs_oobin
fo);


I've also had a chance to run everything and it seems okay.  Although
testing done is pretty minimal.

Christian

> -----Original Message-----
> From: Christian Gan [mailto:cgan@iders.ca]
> Sent: Friday, February 21, 2003 4:53 PM
> To: yaffs@toby-churchill.org
> Subject: RE: [YAFFS]Re: NAND changes
>
>
> Hey people,
>
> I'm just starting to catch up on getting the newest MTD and YAFFS
> to use for
> our board.  I'm having strange problems but I'm just beginning to
> investigate so right now it could be anything (hw or sw).  I'll
> get back to
> you if I get stuck.
>
> BUT, I did have a chance to try the new patch a shot and found a small
> compile error for mkyaffs.c.  I took Thomas' patch and edited it with a
> small change, it is attached.
>
> Changed:
> +	oobsel = usemtdecc ? &yaffs_oobinfo : &yaffs_noeccinfo;
> To:
> +	oobsel = usemtdecc ? yaffs_oobinfo : yaffs_noeccinfo;
>
> Since oobsel is not a pointer.
>
> Christian
>
> > -----Original Message-----
> > From: Charles Manning [mailto:manningc2@actrix.gen.nz]
> > Sent: Thursday, February 20, 2003 2:24 PM
> > To: yaffs@toby-churchill.org
> > Subject: Fwd: [YAFFS]Re: NAND changes
> >
> >
> > Hi Yaffsers
> >
> > Thanx Thomas. Before I check these in I'd like a second set of
> > eyes over these.
> > Could someone try out these patches and get back to me?
> >
> > Thanx
> >
> > -- CHarles
> >
> >
> >
> > ----------  Forwarded Message  ----------
> >
> > Return-Path: <yaffs-request@banenet.co.uk>
> > X-Original-To: manningc2@actrix.gen.nz
> > Delivered-To: manningc2@actrix.gen.nz
> > Received: from blood.actrix.co.nz (unknown [192.168.30.20])
> > 	by blonde.actrix.co.nz (Postfix) with ESMTP id 67A32208050
> > 	for <manningc2@actrix.gen.nz>; Wed, 19 Feb 2003 11:50:38
> > +1300 (NZDT)
> > Received: from cmailm5.svr.pol.co.uk (cmailm5.svr.pol.co.uk
> > [195.92.193.21])
> > 	by blood.actrix.co.nz (Postfix) with ESMTP id B4B2220C12C
> > 	for <manningc2@actrix.gen.nz>; Wed, 19 Feb 2003 11:50:37
> > +1300 (NZDT)
> > Received: from modem-976.gazelle.dialup.pol.co.uk ([81.78.67.208]
> > helo=p133)
> > 	by cmailm5.svr.pol.co.uk with esmtp (Exim 4.10.11)
> > 	id 18lGXQ-0003Ia-00; Tue, 18 Feb 2003 22:48:33 +0000
> > Received: from list by p133 with local (Exim 3.35 #1 (Debian))
> > 	id 18lGjc-0004o2-00; Tue, 18 Feb 2003 23:01:08 +0000
> > Delivered-To: toby-churchill-org-info@toby-churchill.org
> > Delivered-To: toby-churchill-org-yaffs@toby-churchill.org
> > Date: Tue, 18 Feb 2003 23:28:02 +0100
> > From: Thomas Gleixner <tglx@linutronix.de>
> > Subject: Re: NAND changes
> > In-reply-to: <200302181822.03529.tglx@linutronix.de>
> > To: yaffs@toby-churchill.org
> > Cc: manningc2@actrix.gen.nz
> > Reply-To: tglx@linutronix.de
> > Message-id: <200302182328.02908.tglx@linutronix.de>
> > Organization: linutronix
> > MIME-version: 1.0
> > Content-type: multipart/mixed;
> >   boundary="Boundary_(ID_h4GhB29+MM6nsLwOoIsW4A)"
> > User-Agent: KMail/1.4.1
> > References: <200302181430.30132.tglx@linutronix.de>
> >  <200302181822.03529.tglx@linutronix.de>
> > Resent-Message-ID: <S56vuB.A.ogE.zsrU-@p133>
> > Resent-From: yaffs@toby-churchill.org
> > X-Mailing-List: <yaffs@toby-churchill.org> archive/latest/234
> > X-Loop: yaffs@toby-churchill.org
> > List-Post: <mailto:yaffs@toby-churchill.org>
> > List-Help: <mailto:yaffs-request@toby-churchill.org?subject=help>
> > List-Subscribe:
> > <mailto:yaffs-request@toby-churchill.org?subject=subscribe>
> > List-Unsubscribe:
> > <mailto:yaffs-request@toby-churchill.org?subject=unsubscribe>
> > Precedence: list
> > Resent-Sender: yaffs-request@toby-churchill.org
> > Resent-Date: Tue, 18 Feb 2003 23:01:08 +0000
> > Status: R
> > X-Status: N
> > On Tuesday 18 February 2003 18:22, Thomas Gleixner wrote:
> > > Sorry for making noise. I was slightly brain damaged and
> > confused of a lot
> > > of discussions. I'm going to change it again. Will make more noise, if
> > > finished.
> >
> > Making noise again. Attached a patch against current CVS code.
> >
> > Sorry for any disturbance or inconvenience.
> >
> > --
> > Thomas
> > ________________________________________________________________________
> > linutronix - competence in embedded & realtime linux
> > http://www.linutronix.de
> > mail: tglx@linutronix.de
> >
> > -------------------------------------------------------
> >
> >
> >
>