From dirk.behme@googlemail.com Tue Mar 18 06:49:39 2008 Received: from fk-out-0910.google.com ([209.85.128.187]) by stoneboat.aleph1.co.uk with esmtp (Exim 4.63) (envelope-from ) id 1JbVdW-00049x-GR for yaffs@lists.aleph1.co.uk; Tue, 18 Mar 2008 06:49:39 +0000 Received: by fk-out-0910.google.com with SMTP id k31so9418691fkk.14 for ; Mon, 17 Mar 2008 23:49:25 -0700 (PDT) Received: by 10.78.29.6 with SMTP id c6mr438132huc.48.1205822965071; Mon, 17 Mar 2008 23:49:25 -0700 (PDT) Received: from ?192.168.178.25? ( [195.4.48.94]) by mx.google.com with ESMTPS id g1sm41261213muf.5.2008.03.17.23.49.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 17 Mar 2008 23:49:23 -0700 (PDT) Message-ID: <47DF65F1.10201@googlemail.com> Date: Tue, 18 Mar 2008 07:49:21 +0100 From: Dirk Behme User-Agent: Mozilla Thunderbird 1.0.7 (X11/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: yaffs@lists.aleph1.co.uk Content-Type: multipart/mixed; boundary="------------040502070708030805040209" X-SA-Exim-Connect-IP: 209.85.128.187 X-SA-Exim-Mail-From: dirk.behme@googlemail.com X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on stoneboat.aleph1.co.uk X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.2.3 X-SA-Exim-Version: 4.2.1 (built Tue, 09 Jan 2007 17:23:22 +0000) X-SA-Exim-Scanned: Yes (on stoneboat.aleph1.co.uk) Subject: [Yaffs] [PATCH] YAFFS2: Fix warnings in yaffs_guts.c X-BeenThere: yaffs@lists.aleph1.co.uk X-Mailman-Version: 2.1.9 Precedence: list List-Id: Discussion of YAFFS NAND flash filesystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Mar 2008 06:49:39 -0000 This is a multi-part message in MIME format. --------------040502070708030805040209 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Fix warnings fs/yaffs2/yaffs_guts.c: In function 'yaffs_VerifyTnodeWorker': fs/yaffs2/yaffs_guts.c:600: warning: unused variable 'nTnodeBytes' fs/yaffs2/yaffs_guts.c: In function 'yaffs_VerifyFile': fs/yaffs2/yaffs_guts.c:649: warning: unused variable 'ok' fs/yaffs2/yaffs_guts.c: In function 'yaffs_GutsInitialise': fs/yaffs2/yaffs_guts.c:7276: warning: assignment from incompatible pointer type fs/yaffs2/yaffs_guts.c: At top level: fs/yaffs2/yaffs_guts.c:394: warning: 'yaffs_SkipFullVerification' defined but not used fs/yaffs2/yaffs_guts.c: In function 'yaffs_CreateNewObject': fs/yaffs2/yaffs_guts.c:2146: warning: 'tn' may be used uninitialized in this function fs/yaffs2/yaffs_guts.c: In function 'yaffs_MknodObject': fs/yaffs2/yaffs_guts.c:2261: warning: 'str' may be used uninitialized in this function in CVS from today. Signed-off-by: Dirk Behme --------------040502070708030805040209 Content-Type: text/plain; name="yaffs2_warning_fixes_cvs_2008_03_18.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="yaffs2_warning_fixes_cvs_2008_03_18.txt" Index: linux-davinci/fs/yaffs2/yaffs_guts.c =================================================================== --- linux-davinci.orig/fs/yaffs2/yaffs_guts.c +++ linux-davinci/fs/yaffs2/yaffs_guts.c @@ -390,11 +390,6 @@ static int yaffs_SkipVerification(yaffs_ return !(yaffs_traceMask & (YAFFS_TRACE_VERIFY | YAFFS_TRACE_VERIFY_FULL)); } -static int yaffs_SkipFullVerification(yaffs_Device *dev) -{ - return !(yaffs_traceMask & (YAFFS_TRACE_VERIFY_FULL)); -} - static int yaffs_SkipNANDVerification(yaffs_Device *dev) { return !(yaffs_traceMask & (YAFFS_TRACE_VERIFY_NAND)); @@ -597,7 +592,6 @@ static int yaffs_VerifyTnodeWorker(yaffs int i; yaffs_Device *dev = obj->myDev; int ok = 1; - int nTnodeBytes = (dev->tnodeWidth * YAFFS_NTNODES_LEVEL0)/8; if (tn) { if (level > 0) { @@ -646,7 +640,6 @@ static void yaffs_VerifyFile(yaffs_Objec __u32 lastChunk; __u32 x; __u32 i; - int ok; yaffs_Device *dev; yaffs_ExtendedTags tags; yaffs_Tnode *tn; @@ -2143,7 +2136,7 @@ yaffs_Object *yaffs_CreateNewObject(yaff { yaffs_Object *theObject; - yaffs_Tnode *tn; + yaffs_Tnode *tn = NULL; if (number < 0) { number = yaffs_CreateNewObjectNumber(dev); @@ -2258,7 +2251,7 @@ static yaffs_Object *yaffs_MknodObject(y const YCHAR * aliasString, __u32 rdev) { yaffs_Object *in; - YCHAR *str; + YCHAR *str = NULL; yaffs_Device *dev = parent->myDev; @@ -7273,7 +7266,8 @@ int yaffs_GutsInitialise(yaffs_Device * dev->nShortOpCaches = YAFFS_MAX_SHORT_OP_CACHES; } - buf = dev->srCache = YMALLOC(srCacheBytes); + dev->srCache = YMALLOC(srCacheBytes); + buf = (__u8 *)dev->srCache; if(dev->srCache) memset(dev->srCache,0,srCacheBytes); --------------040502070708030805040209--