Re: [Yaffs] duplicate code

I also see this duplicate in nandmtd2_WriteChunkWithTagsToNAND

        if (dev->useNANDECC)
            retval =
                mtd->write_ecc(mtd, addr, dev->nDataBytesPerChunk,
                       &dummy, data, (__u8 *) & pt, NULL);
        else
            retval =
                mtd->write_ecc(mtd, addr, dev->nDataBytesPerChunk,
                       &dummy, data, (__u8 *) & pt, NULL);

Charles Manning <manningc2@actrix.gen.nz> wrote: Thanx Johann

Fixed in cvs.

-- CHarles

On Wednesday 15 November 2006 20:26, Johann Kok (JP) wrote:
> In the function yaffsfs_DoUnlink() I found the following which seems
> to me like duplicate code, but it won't break anything:
>

> else if(isDirectory && obj->variantType !=
> YAFFS_OBJECT_TYPE_DIRECTORY)
> {
>     yaffsfs_SetError(-YAFFS_ENOTDIR, YAFFS_FILE, __LINE__);
> }
> else if(isDirectory && obj->variantType !=
> YAFFS_OBJECT_TYPE_DIRECTORY)
> {
>     yaffsfs_SetError(-YAFFS_ENOTDIR, YAFFS_FILE, __LINE__);
> }

>
> regards
> Johann Kok
>
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> This e-mail and its contents are subject to the Telkom SA Limited
> e-mail legal notice available at
> http://www.telkom.co.za/TelkomEMailLegalNotice.PDF
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> _______________________________________________
> yaffs mailing list
> yaffs@lists.aleph1.co.uk
> http://lists.aleph1.co.uk/cgi-bin/mailman/listinfo/yaffs

_______________________________________________
yaffs mailing list
yaffs@lists.aleph1.co.uk
http://lists.aleph1.co.uk/cgi-bin/mailman/listinfo/yaffs



---------------------------------
Sponsored Link

Want a degree but can't afford to quit? Online degrees from top schools - in as fast as 1 year