Seems in the following calls to yaffs_ReadChunkWithTagsFromNAND()
and yaffs_WriteChunkWithTagsToNAND(), the chunk id's got fixed by a subtraction
of chunkOffset. Not sure other calls using that chunk id. But yes, it
is confusing...
Rong
On Fri, Nov 21, 2008 at 4:25 AM, Cal Page <
pagcal@runbox.com> wrote:
>
> These come from yaffs_ScanBackwards where chunk is calculated as
>
> chunk = blk * dev->nChunksPerBlock + c
>
> but blk is [1..n] not zero based, so shouldn't it be
>
> chunk = (blk-1) * ...
>
> (IMHO, egad, you've got some 0 based indexes and some 1 based indexes.
> It's a sure fire way to introduce bugs. For cleanup, you SHOULD move
> everything to 0 based indexes.)
>
> Cal Page
>
>
> _______________________________________________
> yaffs mailing list
> yaffs@lists.aleph1.co.uk
> http://lists.aleph1.co.uk/cgi-bin/mailman/listinfo/yaffs
>
(text/plain)