On Wednesday 16 September 2009 22:18:06 Wookey wrote:
> Yaffs sets the default mode of the filesystem root dir to 0666. If used
> for a rootfs this actually breaks various things (because / cannot be
> enumerated)
>
> Every other rootfs I have looked at (admittedly all ext2/3) sets the
> default root node mode to 0755. Is there good reason why the yaffs
> default is different? It doesn't even seem to add any security because
> every has write access with 0666.
>
> This patch fixes it for us, but it just feels like something that
> maybe should be in upstream:
>
> Index: linux-2.6.29.1/fs/yaffs2/yportenv.h
> ===================================================================
> --- linux-2.6.29.1.orig/fs/yaffs2/yportenv.h 2009-09-15
> 18:30:04.000000000 +0100 +++ linux-2.6.29.1/fs/yaffs2/yportenv.h 2009-09-15
> 18:33:16.000000000 +0100 @@ -74,7 +74,7 @@
> /* KR - added for use in scan so processes aren't blocked indefinitely. */
> #define YYIELD() schedule()
>
> -#define YAFFS_ROOT_MODE 0666
> +#define YAFFS_ROOT_MODE 0755
> #define YAFFS_LOSTNFOUND_MODE 0666
>
I've changed this to root=0755, lost+found=0700 as per:
http://www.aleph1.co.uk/cgi-bin/viewcvs.cgi/yaffs2/yportenv.h?r1=1.23&r2=1.24
-- CHarles
(text/plain)