Re: [Yaffs] Weirndess testing YAFFS2 with large files - md5s…

No, it did not - however it exhibited some random behavior.  Previous
version was pulled from 20090909 and my thought was with the current
changes to handle large file yaffs_Tnode handling it would help -
version strings are:

peter@blitz:~/work/logic/eps_svn/software/products/linux/LTIB/trunk/ltib-20091102-som/rpm/BUILD/linux-2.6.28-rc8$ grep '\$Id:' fs/yaffs2/*.[hc]
fs/yaffs2/yaffs_checkptrw.c:    "$Id: yaffs_checkptrw.c,v 1.20 2009-09-09
03:03:01 charles Exp $";
fs/yaffs2/yaffs_ecc.c:    "$Id: yaffs_ecc.c,v 1.11 2009-03-06 17:20:50
wookey Exp $";
fs/yaffs2/yaffs_fs.c:    "$Id: yaffs_fs.c,v 1.82 2009-09-18 00:39:21
charles Exp $";
fs/yaffs2/yaffs_guts.c:    "$Id: yaffs_guts.c,v 1.89 2009-09-09 00:56:53
charles Exp $";
fs/yaffs2/yaffs_mtdif1.c:const char *yaffs_mtdif1_c_version = "$Id:
yaffs_mtdif1.c,v 1.11 2009-09-09 03:03:01 charles Exp $";
fs/yaffs2/yaffs_mtdif2.c:    "$Id: yaffs_mtdif2.c,v 1.23 2009-03-06
17:20:53 wookey Exp $";
fs/yaffs2/yaffs_mtdif.c:    "$Id: yaffs_mtdif.c,v 1.22 2009-03-06 17:20:51
wookey Exp $";
fs/yaffs2/yaffs_nand.c:    "$Id: yaffs_nand.c,v 1.11 2009-09-09 03:03:01
charles Exp $";

I'll go back and re-test with that version to grnerate the output.  The
original test did the dd command with "dd if-/dev/urandom of=somefile.$i
count=0 bs=0 skip=30M" to seek out 30MB after the open and then close
the file - initially I thought the test was off as that dd command
wouldn't generate any actual data on an EXT3 device.

The MTD layer has performed flawlessly with the previous version(s), so
I'm not thinking the MTD ECC handling itself is in error - I can add
code to dump it if finds an ECC error on read; I noticed that the
current code doesn't verify the data written if
"CONFIG_YAFFS_ALWAYS_CHECK_CHUNK_ERASED" is not set - do you have a
development patch that enables the readback to verify the chunk is
written correctly so I can test that my MTD layer is still operating
correctly?

> >
> > First off I had to modify the code in  yaffs_write_begin to only call
> > grab_cache_pages_write_begin if the kernel version is newer than 2.6.28
> > since 2.6.28-rc8 does *not* have __grab_cache_page whereas 2.6.28 proper
> > does:
> >
> > #if LINUX_VERSION_CODE > KERNEL_VERSION(2, 6, 28)
> >     pg = grab_cache_page_write_begin(mapping, index, flags);
> > #else
> >     pg = __grab_cache_page(mapping, index);
> > #endif
> 
> That is an unfortunate problem due to there being no way to conditionally 
> compile against rc and other sub-version markers. I originally had this the 
> way you have it now, but changed it.