[Yaffs] [RFC] mkyaffs2image creates unmountable image

Top Page
Attachments:
Message as email
+ (text/plain)
Delete this message
Reply to this message
Author: Yegor Yefremov
Date:  
To: yaffs
Subject: [Yaffs] [RFC] mkyaffs2image creates unmountable image
Hi,

I've tried to compile the Android's system image. For this purpose
I've cloned your git repo and compiled mkyaffs2image utility. During
the compilation process I noticed following warnings:

mkyaffs2image.c:249: warning: array subscript is above array bounds

after creating an image and burning it with nandwrite -a -o /dev/mtdx
system.img I was not able to mount it afterwards. So I've resized the
roomToGrow array so the warnings went away and after compiling the
image with new binary I could successfully mount and brows the image.

The test system was an ARM based board running Debian with Android's
kernel 2.6.32.

Regards,
Yegor

Enlarge roomToGrow array size, so that following warnings disappear and
the array will be filled correctly:

mkyaffs2image.c:249: warning: array subscript is above array bounds

Signed-off-by: Yegor Yefremov <>

Index: b/yaffs_guts.h
===================================================================
--- a/yaffs_guts.h    2010-07-26 11:14:42.000000000 +0200
+++ b/yaffs_guts.h    2010-07-27 16:43:47.000000000 +0200
@@ -334,7 +334,7 @@
     __u32 win_atime[2];
     __u32 win_mtime[2];
 #else
-    __u32 roomToGrow[6];
+    __u32 roomToGrow[12];


 #endif
     __u32 inbandShadowsObject;