[Yaffs] Checking for ecc_result == -YAFFS_ECC_RESULT_FIXED

Top Page
Attachments:
Message as email
+ (text/plain)
+ (text/html)
Delete this message
Reply to this message
Author: Mykelyk
Date:  
To: yaffs
Subject: [Yaffs] Checking for ecc_result == -YAFFS_ECC_RESULT_FIXED
Hi,

in the file yaffs_tagsmarshall.c on the line 121-125:

if (tags && ecc_result == -YAFFS_ECC_RESULT_FIXED) {
if (tags->ecc_result <= YAFFS_ECC_RESULT_NO_ERROR)
tags->ecc_result = YAFFS_ECC_RESULT_FIXED;
dev->n_ecc_fixed++;
}

Should not be checking for YAFFS_ECC_RESULT_FIXED (without the minus sign)
instead? I cannot find in the code any other instance of negative
ecc_result.

Best regards
Michele Artoni