[Yaffs] Build error on 2.6.19 and my thoughts about the sour…

Hi all,

The error I encounted is exactly as Claudio Lanconelli's post here
several days ago.
=====================================================
fs/yaffs2/yaffs_fs.c: In function `yaffs_readlink':
fs/yaffs2/yaffs_fs.c:263: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:267: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_follow_link':
fs/yaffs2/yaffs_fs.c:287: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:291: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_lookup':
fs/yaffs2/yaffs_fs.c:328: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:332: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:337: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_clear_inode':
fs/yaffs2/yaffs_fs.c:396: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:411: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_delete_inode':
fs/yaffs2/yaffs_fs.c:432: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_file_flush':
fs/yaffs2/yaffs_fs.c:458: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_readpage_nolock':
fs/yaffs2/yaffs_fs.c:489: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_writepage':
fs/yaffs2/yaffs_fs.c:589: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_FillInodeFromObject':
fs/yaffs2/yaffs_fs.c:707: error: structure has no member named `i_blksize'
fs/yaffs2/yaffs_fs.c:759: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_file_write':
fs/yaffs2/yaffs_fs.c:808: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_readdir':
fs/yaffs2/yaffs_fs.c:868: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_mknod':
fs/yaffs2/yaffs_fs.c:962: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_unlink':
fs/yaffs2/yaffs_fs.c:1077: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:1081: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_link':
fs/yaffs2/yaffs_fs.c:1107: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:1115: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_symlink':
fs/yaffs2/yaffs_fs.c:1150: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:1152: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_sync_object':
fs/yaffs2/yaffs_fs.c:1179: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_rename':
fs/yaffs2/yaffs_fs.c:1203: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:1209: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:1227: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:1229: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_setattr':
fs/yaffs2/yaffs_fs.c:1254: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:1260: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c:1262: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: In function `yaffs_statfs':
fs/yaffs2/yaffs_fs.c:1278: error: structure has no member named `u'
fs/yaffs2/yaffs_fs.c: At top level:
=====================================================
Has the patch been applied in CVS?

Another issue is my thoughts about the source code.
In my opinion, the current source code is terrible. KERNEL VERSION
macros is everywhere. I hate it very much. It caused the code ugly.
Since we have the CVS, why not maintain it by cvs tag/branch? for
example tag_2-6-18 for kernel(2,6,18), tag_2-6-19 for kernel(2,6,19)?

If we still add kernel version control in the source code, the code
will become more and more un-maintainable soon.

-Aubrey