I have done some more clean up on top of the Wookey/Noodles effort.
This cleans up white spaces, braces and some other issues as well as removing
some obsolete code.
The main areas that are currently still non-compliant are:
1) Lines longer than 80 char.
2) Some warnings re CVS tags.
3) typedefs (Linus does not like these).
btw: Checkpatch can also be run with the --file option to check a file instead
of a patch.
I have eyeballed the changes and I don't think anything got broken.
-- Charles
On Monday 09 March 2009 15:36:24 Charles Manning wrote:
> On Saturday 07 March 2009 06:59:12 Wookey wrote:
> > I've just checked in a huge patch making yaffs2 follow the Linux
> > kernel code style (as defined by checkpatch.pl).
> >
> > Sorry about the mess this will make of any existing patches you are
> > working with, and general pain, but the last time we tidied things up
> > was August 2005, and this is a necessary prerequisite to getting yaffs
> > into mainline.
> >
> > We've tried hard not to change anything other than style, and the new
> > code is working fine here with 2.9.29-rc7, but do tell us if you find
> > problems.
> >
> > There is a tag 'pre-checkpatch-20090306' for the codebase as of last
> > night which includes all the recent 2.6.29 fixes. If that works for
> > you and current HEAD doesn't then it's probably my/Noodles fault.
> >
> > Wookey
>
> Curous as to how you did this and checked it...
>
> Running checkpatch with --file allows you to run this on files instead of
> patches.
>
> When I do that on a fresh cvs checkout I still get 11 "code indent should
> use tabs" on yaffs_guts.c
>
> -- Charles
>
>
>
>
> _______________________________________________
> yaffs mailing list
> yaffs@lists.aleph1.co.uk
> http://lists.aleph1.co.uk/cgi-bin/mailman/listinfo/yaffs
(text/plain)