+++ Charles Manning [2009-03-09 15:36 +1300]:
> On Saturday 07 March 2009 06:59:12 Wookey wrote:
> > I've just checked in a huge patch making yaffs2 follow the Linux
> > kernel code style (as defined by checkpatch.pl).
>
> Curous as to how you did this and checked it...
>
> Running checkpatch with --file allows you to run this on files instead of
> patches.
>
> When I do that on a fresh cvs checkout I still get 11 "code indent should use
> tabs" on yaffs_guts.c
[which Charles has now fixed, along with some more tidy-up]
Not sure how those got missed. I suspect it's my cock-up aided the
changes in cvs overlapping the cleanup, possibly caused by me only
checking diffs between 'yaffs-cvs' and 'yaffs-cleanup', not original
files, after Noodles initial massive cleanup.
Most of the other change you've made (unnecessary braces removal) is
because that was only a warning so for initial patch we left it alone.
Anyway. I've merged your further cleanups into my 'yaffs-cleanup'
tree, which has flushed out a few more tiny fixups, which I'll check
in shortly.
You have left in a couple of #if 0 sections of code in yaffs_fs.c. Is
there a good reason to keep them around?
Wookey
--
Principal hats: iEndian - Balloonboard - Toby Churchill - Emdebian
http://wookware.org/
(text/plain)